[Aerogear-users] cordova push plugin.xml namespace

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Aerogear-users] cordova push plugin.xml namespace

Kelvin Lunsford
Can someone please modify plugin.xml so the xmlns:android namespace attribute is in the top-level element as specified in the plugin.xml documentation (https://cordova.apache.org/docs/en/5.1.1/plugin_ref_spec.md.html), and take the xmlns:android attributes out of the lower elements.

If the namespace is not changed problems will occur when installing the push plugin along with any other plugin containing one of the push plugins android permissions (e.g. cordova-plugin-contacts uses GET_ACCOUNTS, cordova-plugin-wakeuptimer uses WAKE_LOCK).

Cordova CLI can deal with the same android permission used by multiple plugins but will install an invalid extra copy of a permission if it includes a xmlns:android attribute.

The android ACCESS_NETWORK_STATE permission was removed by aerogear in the latest release because of AGCORDOVA-72.  The cause of the AGCORDOVA-72 problem was most likely the namespace problem.  The permission should not have been removed.

- Kelvin


_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Aerogear-users] cordova push plugin.xml namespace

Erik Jan de Wit
Right, good find! I've created a PR for this https://github.com/aerogear/aerogear-cordova-push/pull/72 maybe you can try it out?

cordova plugin add <a href="https://github.com/edewit/aerogear-pushplugin-cordova\#namespace-fix">https://github.com/edewit/aerogear-pushplugin-cordova\#namespace-fix

On Tue, Jul 7, 2015 at 2:59 AM, Kelvin Lunsford <[hidden email]> wrote:
Can someone please modify plugin.xml so the xmlns:android namespace attribute is in the top-level element as specified in the plugin.xml documentation (https://cordova.apache.org/docs/en/5.1.1/plugin_ref_spec.md.html), and take the xmlns:android attributes out of the lower elements.

If the namespace is not changed problems will occur when installing the push plugin along with any other plugin containing one of the push plugins android permissions (e.g. cordova-plugin-contacts uses GET_ACCOUNTS, cordova-plugin-wakeuptimer uses WAKE_LOCK).

Cordova CLI can deal with the same android permission used by multiple plugins but will install an invalid extra copy of a permission if it includes a xmlns:android attribute.

The android ACCESS_NETWORK_STATE permission was removed by aerogear in the latest release because of AGCORDOVA-72.  The cause of the AGCORDOVA-72 problem was most likely the namespace problem.  The permission should not have been removed.

- Kelvin


_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users



--
Cheers,
       Erik Jan

_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Aerogear-users] cordova push plugin.xml namespace

Kelvin Lunsford
Thanks Erik,

The latest commit should fix the permission problem I was seeing.

The plugin.xml file still has unneeded xmlns:android namespace attributes in elements on lines 35, 38, and 39.

- Kelvin

------------------------------------------------------------------------------------

From: [hidden email] [mailto:[hidden email]] On Behalf Of Erik Jan de Wit
Sent: Tuesday, July 07, 2015 2:17 AM
To: [hidden email]
Subject: Re: [Aerogear-users] cordova push plugin.xml namespace

Right, good find! I've created a PR for this https://github.com/aerogear/aerogear-cordova-push/pull/72 maybe you can try it out?

cordova plugin add https://github.com/edewit/aerogear-pushplugin-cordova\#namespace-fix

On Tue, Jul 7, 2015 at 2:59 AM, Kelvin Lunsford <[hidden email]> wrote:
Can someone please modify plugin.xml so the xmlns:android namespace attribute is in the top-level element as specified in the plugin.xml documentation (https://cordova.apache.org/docs/en/5.1.1/plugin_ref_spec.md.html), and take the xmlns:android attributes out of the lower elements.

If the namespace is not changed problems will occur when installing the push plugin along with any other plugin containing one of the push plugins android permissions (e.g. cordova-plugin-contacts uses GET_ACCOUNTS, cordova-plugin-wakeuptimer uses WAKE_LOCK).

Cordova CLI can deal with the same android permission used by multiple plugins but will install an invalid extra copy of a permission if it includes a xmlns:android attribute.

The android ACCESS_NETWORK_STATE permission was removed by aerogear in the latest release because of AGCORDOVA-72.  The cause of the AGCORDOVA-72 problem was most likely the namespace problem.  The permission should not have been removed.

- Kelvin


_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users




--
Cheers,
       Erik Jan

_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Aerogear-users] cordova push plugin.xml namespace

Erik Jan de Wit
fixed

On Tue, Jul 7, 2015 at 11:43 PM, Kelvin Lunsford <[hidden email]> wrote:
Thanks Erik,

The latest commit should fix the permission problem I was seeing.

The plugin.xml file still has unneeded xmlns:android namespace attributes in elements on lines 35, 38, and 39.

- Kelvin

------------------------------------------------------------------------------------

From: [hidden email] [mailto:[hidden email]] On Behalf Of Erik Jan de Wit
Sent: Tuesday, July 07, 2015 2:17 AM
To: [hidden email]
Subject: Re: [Aerogear-users] cordova push plugin.xml namespace

Right, good find! I've created a PR for this https://github.com/aerogear/aerogear-cordova-push/pull/72 maybe you can try it out?

cordova plugin add <a href="https://github.com/edewit/aerogear-pushplugin-cordova\#namespace-fix" rel="noreferrer" target="_blank">https://github.com/edewit/aerogear-pushplugin-cordova\#namespace-fix

On Tue, Jul 7, 2015 at 2:59 AM, Kelvin Lunsford <[hidden email]> wrote:
Can someone please modify plugin.xml so the xmlns:android namespace attribute is in the top-level element as specified in the plugin.xml documentation (https://cordova.apache.org/docs/en/5.1.1/plugin_ref_spec.md.html), and take the xmlns:android attributes out of the lower elements.

If the namespace is not changed problems will occur when installing the push plugin along with any other plugin containing one of the push plugins android permissions (e.g. cordova-plugin-contacts uses GET_ACCOUNTS, cordova-plugin-wakeuptimer uses WAKE_LOCK).

Cordova CLI can deal with the same android permission used by multiple plugins but will install an invalid extra copy of a permission if it includes a xmlns:android attribute.

The android ACCESS_NETWORK_STATE permission was removed by aerogear in the latest release because of AGCORDOVA-72.  The cause of the AGCORDOVA-72 problem was most likely the namespace problem.  The permission should not have been removed.

- Kelvin


_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users




--
Cheers,
       Erik Jan

_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users



--
Cheers,
       Erik Jan

_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Aerogear-users] cordova push plugin.xml namespace

Erik Jan de Wit
thanks

On Wed, Jul 8, 2015 at 9:57 AM, Erik Jan de Wit <[hidden email]> wrote:
fixed

On Tue, Jul 7, 2015 at 11:43 PM, Kelvin Lunsford <[hidden email]> wrote:
Thanks Erik,

The latest commit should fix the permission problem I was seeing.

The plugin.xml file still has unneeded xmlns:android namespace attributes in elements on lines 35, 38, and 39.

- Kelvin

------------------------------------------------------------------------------------

From: [hidden email] [mailto:[hidden email]] On Behalf Of Erik Jan de Wit
Sent: Tuesday, July 07, 2015 2:17 AM
To: [hidden email]
Subject: Re: [Aerogear-users] cordova push plugin.xml namespace

Right, good find! I've created a PR for this https://github.com/aerogear/aerogear-cordova-push/pull/72 maybe you can try it out?

cordova plugin add https://github.com/edewit/aerogear-pushplugin-cordova\#namespace-fix

On Tue, Jul 7, 2015 at 2:59 AM, Kelvin Lunsford <[hidden email]> wrote:
Can someone please modify plugin.xml so the xmlns:android namespace attribute is in the top-level element as specified in the plugin.xml documentation (https://cordova.apache.org/docs/en/5.1.1/plugin_ref_spec.md.html), and take the xmlns:android attributes out of the lower elements.

If the namespace is not changed problems will occur when installing the push plugin along with any other plugin containing one of the push plugins android permissions (e.g. cordova-plugin-contacts uses GET_ACCOUNTS, cordova-plugin-wakeuptimer uses WAKE_LOCK).

Cordova CLI can deal with the same android permission used by multiple plugins but will install an invalid extra copy of a permission if it includes a xmlns:android attribute.

The android ACCESS_NETWORK_STATE permission was removed by aerogear in the latest release because of AGCORDOVA-72.  The cause of the AGCORDOVA-72 problem was most likely the namespace problem.  The permission should not have been removed.

- Kelvin


_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users




--
Cheers,
       Erik Jan

_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users



--
Cheers,
       Erik Jan



--
Cheers,
       Erik Jan

_______________________________________________
Aerogear-users mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-users
Loading...